Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color log markers by user-specified log fields #2369

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SOF3
Copy link
Contributor

@SOF3 SOF3 commented Jul 4, 2024

Which problem is this PR solving?

Description of the changes

  • Add a settings dialog to TracePage
  • Add an option to select log marker color keys
  • Change log marker colors from black to colorgenerator-based (same color generator as span bars, but with only 2/3 brightness to avoid producing identical colors)
image

How was this change tested?

(This is my first time working with a reactjs project, would appreciate pointers to what tests I need to write)

Checklist

@yurishkuro
Copy link
Member

what is the meaning of multiple colors on the same tick?

image

Comment on lines +62 to +64
availableTagKeys: string[];
selectedMarkerColorKey: string[];
setMarkerColorKey: (tagKey: string[]) => void;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These don't seem relevant in any way to the "page header" type. Is it possible to use the Context API to keep the knowledge of the settings only to the components that actually need this knowledge, such as the Settings popup and the SpanBar that renders the ticks?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Colormap log markers by tag
2 participants