-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Kafka exporter and receiver configuration #5687
Conversation
Signed-off-by: Joeyyy09 <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5687 +/- ##
===========================================
- Coverage 96.38% 54.13% -42.25%
===========================================
Files 329 163 -166
Lines 16060 8412 -7648
===========================================
- Hits 15479 4554 -10925
- Misses 404 3414 +3010
- Partials 177 444 +267
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
"go.opentelemetry.io/collector/receiver/receivertest" | ||
) | ||
|
||
type kafkaDataReceiver struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this for?
@@ -0,0 +1,32 @@ | |||
service: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this file? Ingester with memory storage doesn't make a lot of sense, since nothing else can access that storage. And you also have jaeger_query enabled, which doesn't fit the meaning of ingester.
extensions: | ||
jaeger_storage: | ||
grpc: | ||
external-storage: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use name that doesn't look like it's part of the config struct
external-storage: | |
some-external-storage: |
|
||
exporters: | ||
jaeger_storage_exporter: | ||
trace_storage: memstore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
trace_storage: memstore | |
trace_storage: some-external-storage |
@@ -87,6 +87,30 @@ require ( | |||
gopkg.in/yaml.v3 v3.0.1 | |||
) | |||
|
|||
require ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is gomod changing?
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger
:make lint test
jaeger-ui
:yarn lint
andyarn test