Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kafka exporter and receiver configuration #5687

Closed
wants to merge 1 commit into from

Conversation

joeyyy09
Copy link
Member

Which problem is this PR solving?

Description of the changes

  • Create collector-with-kafka.yaml and ingester.yaml

How was this change tested?

Checklist

Copy link

codecov bot commented Jun 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.13%. Comparing base (1c1bc08) to head (f383ba0).
Report is 5 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (1c1bc08) and HEAD (f383ba0). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (1c1bc08) HEAD (f383ba0)
unittests 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5687       +/-   ##
===========================================
- Coverage   96.38%   54.13%   -42.25%     
===========================================
  Files         329      163      -166     
  Lines       16060     8412     -7648     
===========================================
- Hits        15479     4554    -10925     
- Misses        404     3414     +3010     
- Partials      177      444      +267     
Flag Coverage Δ
badger_v1 8.04% <ø> (ø)
badger_v2 1.92% <ø> (ø)
cassandra-3.x-v1 16.60% <ø> (ø)
cassandra-3.x-v2 1.84% <ø> (ø)
cassandra-4.x-v1 16.60% <ø> (ø)
cassandra-4.x-v2 1.84% <ø> (ø)
elasticsearch-7.x-v1 18.88% <ø> (ø)
elasticsearch-8.x-v1 19.08% <ø> (+0.01%) ⬆️
elasticsearch-8.x-v2 19.07% <ø> (-0.02%) ⬇️
grpc_v1 9.47% <ø> (ø)
grpc_v2 7.49% <ø> (ø)
kafka 9.76% <ø> (ø)
opensearch-1.x-v1 18.92% <ø> (-0.02%) ⬇️
opensearch-2.x-v1 18.92% <ø> (-0.02%) ⬇️
opensearch-2.x-v2 18.92% <ø> (ø)
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

"go.opentelemetry.io/collector/receiver/receivertest"
)

type kafkaDataReceiver struct {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this for?

@@ -0,0 +1,32 @@
service:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this file? Ingester with memory storage doesn't make a lot of sense, since nothing else can access that storage. And you also have jaeger_query enabled, which doesn't fit the meaning of ingester.

extensions:
jaeger_storage:
grpc:
external-storage:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use name that doesn't look like it's part of the config struct

Suggested change
external-storage:
some-external-storage:


exporters:
jaeger_storage_exporter:
trace_storage: memstore
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
trace_storage: memstore
trace_storage: some-external-storage

@@ -87,6 +87,30 @@ require (
gopkg.in/yaml.v3 v3.0.1
)

require (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is gomod changing?

@joeyyy09 joeyyy09 closed this Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Jaeger v2] Add Kafka exporter and receiver
2 participants