Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] [hotrod] Delay env var mapping until logger is initialized #5760

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

yurishkuro
Copy link
Member

Which problem is this PR solving?

Description of the changes

  • Invoke mapping function (which takes logger) after the logger is initialized
  • It is safe to do because none of the env vars control the logic for logger initialization

How was this change tested?

  • $ JAEGER_AGENT_PORT=xyz go run ./examples/hotrod all
  • Before the change this command would cause a panic

@yurishkuro yurishkuro requested a review from a team as a code owner July 17, 2024 15:39
@dosubot dosubot bot added the go label Jul 17, 2024
@yurishkuro yurishkuro changed the title [hotrod] Delay env var mapping until logger is initialized [bug] [hotrod] Delay env var mapping until logger is initialized Jul 17, 2024
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.65%. Comparing base (d3c7d67) to head (fffb275).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5760      +/-   ##
==========================================
- Coverage   96.67%   96.65%   -0.03%     
==========================================
  Files         341      341              
  Lines       16451    16451              
==========================================
- Hits        15904    15900       -4     
- Misses        360      362       +2     
- Partials      187      189       +2     
Flag Coverage Δ
badger_v1 8.05% <ø> (ø)
badger_v2 1.90% <ø> (ø)
cassandra-3.x-v1 16.61% <ø> (ø)
cassandra-3.x-v2 1.82% <ø> (ø)
cassandra-4.x-v1 16.61% <ø> (ø)
cassandra-4.x-v2 1.82% <ø> (ø)
elasticsearch-6.x-v1 18.77% <ø> (-0.02%) ⬇️
elasticsearch-7.x-v1 18.84% <ø> (ø)
elasticsearch-8.x-v1 19.02% <ø> (ø)
elasticsearch-8.x-v2 1.90% <ø> (+0.01%) ⬆️
grpc_v1 9.52% <ø> (ø)
grpc_v2 7.46% <ø> (-0.02%) ⬇️
kafka 9.74% <ø> (ø)
memory_v2 1.90% <ø> (ø)
opensearch-1.x-v1 18.89% <ø> (+0.01%) ⬆️
opensearch-2.x-v1 18.88% <ø> (-0.02%) ⬇️
opensearch-2.x-v2 1.90% <ø> (ø)
unittests 95.07% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro merged commit c68136e into jaegertracing:main Jul 17, 2024
42 of 45 checks passed
@yurishkuro yurishkuro deleted the fix-5759 branch July 17, 2024 15:53
FlamingSaint pushed a commit to FlamingSaint/jaeger that referenced this pull request Jul 20, 2024
…gertracing#5760)

## Which problem is this PR solving?
- Resolves jaegertracing#5759 

## Description of the changes
- Invoke mapping function (which takes logger) after the logger is
initialized
- It is safe to do because none of the env vars control the logic for
logger initialization

## How was this change tested?
- `$ JAEGER_AGENT_PORT=xyz go run ./examples/hotrod  all`
- Before the change this command would cause a panic

Signed-off-by: Yuri Shkuro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: HotRod run failed if using the old env variable
2 participants