Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OTLP JSON support for Kafka e2e Integration tests #5935

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

joeyyy09
Copy link
Member

@joeyyy09 joeyyy09 commented Sep 4, 2024

Which problem is this PR solving?

  • This PR addresses the issue of verifying Kafka e2e integration tests for otlp_json formats.

Description of the changes

  • Verified if the Kafka e2e integration tests run for otlp_json formats.
  • Used a fork of mine (github.com/joeyyy09/opentelemetry-collector-contrib) to incorporate necessary changes and verify the process.

How was this change tested?

  • Ran the Kafka e2e integration tests locally using the modified configuration.

Checklist

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.78%. Comparing base (8d1a955) to head (dbb0f77).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5935   +/-   ##
=======================================
  Coverage   96.78%   96.78%           
=======================================
  Files         348      348           
  Lines       16559    16559           
=======================================
  Hits        16027    16027           
  Misses        343      343           
  Partials      189      189           
Flag Coverage Δ
badger_v1 8.02% <ø> (ø)
badger_v2 1.82% <ø> (ø)
cassandra-4.x-v1 16.61% <ø> (ø)
cassandra-4.x-v2 1.75% <ø> (ø)
cassandra-5.x-v1 16.61% <ø> (ø)
cassandra-5.x-v2 1.75% <ø> (ø)
elasticsearch-6.x-v1 18.78% <ø> (ø)
elasticsearch-7.x-v1 18.84% <ø> (ø)
elasticsearch-8.x-v1 19.04% <ø> (ø)
elasticsearch-8.x-v2 1.81% <ø> (-0.02%) ⬇️
grpc_v1 9.52% <ø> (ø)
grpc_v2 7.15% <ø> (ø)
kafka-v1 9.74% <ø> (ø)
kafka-v2 ?
memory_v2 1.82% <ø> (+0.01%) ⬆️
opensearch-1.x-v1 18.88% <ø> (ø)
opensearch-2.x-v1 18.88% <ø> (-0.02%) ⬇️
opensearch-2.x-v2 1.82% <ø> (ø)
tailsampling-processor 0.46% <ø> (ø)
unittests 95.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro
Copy link
Member

please link to OTEL PR

@yurishkuro yurishkuro added the changelog:exprimental Change to an experimental part of the code label Sep 9, 2024
@joeyyy09 joeyyy09 marked this pull request as ready for review September 16, 2024 09:47
@joeyyy09 joeyyy09 requested a review from a team as a code owner September 16, 2024 09:47
@joeyyy09
Copy link
Member Author

will be good to go after the next release of otel-collector-contrib

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:exprimental Change to an experimental part of the code storage/kafka
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants