Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linter errors from deprecations in OTEL 0.110 #6016

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

won-js
Copy link
Contributor

@won-js won-js commented Sep 24, 2024

Which problem is this PR solving?

Description of the changes

  • fix linter deprecation errors to use new APIs

How was this change tested?

  • Unit test

Checklist

…inter errors from deprecations in OTEL 0.110 jaegertracing#6013

Signed-off-by: Joonsoo Won <[email protected]>
@won-js won-js requested a review from a team as a code owner September 24, 2024 08:50
@won-js won-js force-pushed the all-otel-collector-packages branch 2 times, most recently from a7468d2 to c276dea Compare September 24, 2024 09:14
Signed-off-by: Joonsoo Won <[email protected]>
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yurishkuro yurishkuro added the changelog:dependencies Update to dependencies label Sep 24, 2024
@yurishkuro yurishkuro enabled auto-merge (squash) September 24, 2024 13:32
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.78%. Comparing base (5061ce3) to head (a723311).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ger/internal/extension/remotesampling/extension.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6016      +/-   ##
==========================================
+ Coverage   96.72%   96.78%   +0.06%     
==========================================
  Files         348      348              
  Lines       16559    16562       +3     
==========================================
+ Hits        16016    16030      +14     
+ Misses        355      343      -12     
- Partials      188      189       +1     
Flag Coverage Δ
badger_v1 8.02% <0.00%> (-0.01%) ⬇️
badger_v2 1.82% <0.00%> (-0.01%) ⬇️
cassandra-4.x-v1 16.60% <0.00%> (-0.01%) ⬇️
cassandra-4.x-v2 1.75% <0.00%> (-0.01%) ⬇️
cassandra-5.x-v1 16.60% <0.00%> (-0.01%) ⬇️
cassandra-5.x-v2 1.75% <0.00%> (-0.01%) ⬇️
elasticsearch-6.x-v1 18.78% <0.00%> (-0.01%) ⬇️
elasticsearch-7.x-v1 18.82% <0.00%> (-0.02%) ⬇️
elasticsearch-8.x-v1 19.03% <0.00%> (?)
elasticsearch-8.x-v2 1.82% <0.00%> (-0.01%) ⬇️
grpc_v1 9.55% <83.33%> (+0.03%) ⬆️
grpc_v2 7.15% <0.00%> (-0.01%) ⬇️
kafka-v1 9.74% <0.00%> (-0.01%) ⬇️
kafka-v2 1.82% <0.00%> (-0.01%) ⬇️
memory_v2 1.82% <0.00%> (+0.01%) ⬆️
opensearch-1.x-v1 18.88% <0.00%> (-0.01%) ⬇️
opensearch-2.x-v1 18.88% <0.00%> (-0.01%) ⬇️
opensearch-2.x-v2 1.82% <0.00%> (?)
tailsampling-processor 0.46% <0.00%> (-0.01%) ⬇️
unittests 95.27% <90.90%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro merged commit 2ab2b31 into jaegertracing:main Sep 24, 2024
49 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix linter errors from deprecations in OTEL 0.110
2 participants