Remove some unnecessary ifdefs #1679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
according to the manpage, it won't have any effect on 64bit system anyways. and musl always uses 64bit so this macro doesn't have any effect there either.
N-R-K
force-pushed
the
ifdef_fixes
branch
2 times, most recently
from
9e10a12
to
4e420e7
Compare
|
Okay, I give up. No clue why macos is failing, it is completely evil. Had to drop the commit be5bf3e because macos keeps failing with it. |
N-R-K
force-pushed
the
ifdef_fixes
branch
2 times, most recently
from
b5e9639
to
8fdf35e
Compare
jarun
requested changes
Jul 4, 2023
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
define _FILE_OFFSET_BITS 64 unconditionally
according to the manpage, it won't have any effect on 64bit system
anyways. and musl always uses 64bit so this macro doesn't have any
effect there either.