Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dirs in context color fix #1898

Merged
merged 1 commit into from
Jun 23, 2024
Merged

Conversation

a-gruzdev
Copy link
Contributor

When you launch nnn -D , directories use some default color instead of context color

I made some investigation and found out that this check if (color_pair && fcolors[color_pair]) is always false for context colors, as it's values in fcolors are always 0.
dbg

I added it's initialization in initcurses to fix this. Now it looks like this
col1
col2

@jarun
Copy link
Owner

jarun commented Jun 23, 2024

Did you test without -D to confirm there are no side effects?

Copy link
Collaborator

@N-R-K N-R-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me. Did some light testing and everything seems to work as expected.

@a-gruzdev
Copy link
Contributor Author

yes, tested without -D, dirs use their color from fcolors (blue by default), and everything else works as expected

@N-R-K N-R-K linked an issue Jun 23, 2024 that may be closed by this pull request
9 tasks
@jarun jarun merged commit 86d883e into jarun:master Jun 23, 2024
7 checks passed
@jarun
Copy link
Owner

jarun commented Jun 23, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dirs in context color (-D) not working
3 participants