Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed a bug in css.html not defaulting media attribute to 'all'. #685

Merged
merged 1 commit into from
Dec 20, 2019
Merged

Fixed a bug in css.html not defaulting media attribute to 'all'. #685

merged 1 commit into from
Dec 20, 2019

Conversation

KFoxder
Copy link
Member

@KFoxder KFoxder commented Feb 17, 2019

The documentation for the extra_context option says:

For CSS, if you do not specify extra_context/media, the default media in the output will be media="all".

Related Issue: #684

@KFoxder
Fixed a bug in css.html not defaulting media attr to 'all'.
8a4cea9 
- Added a test case to support this scenario
@KFoxder
Copy link
Member Author

KFoxder commented Feb 17, 2019

@cyberdelia Would you mind taking a look at his when you have some time or assign another maintainer to review it? Thanks in advance 👍

@coveralls
Copy link

Coverage Status

Coverage remained the same at 82.133% when pulling 8a4cea9 on KFoxder:fix_css_html_tempalte into 3cd2f93 on jazzband:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 82.133% when pulling 8a4cea9 on KFoxder:fix_css_html_tempalte into 3cd2f93 on jazzband:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 82.133% when pulling 8a4cea9 on KFoxder:fix_css_html_tempalte into 3cd2f93 on jazzband:master.

@KFoxder KFoxder merged commit 3086bde into jazzband:master Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KFoxder @coveralls