Optimizations #32
Open
Optimizations #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Building arrays via `arr[i] = x` is faster than `arr.push(x)`. Store references to morv.elements.
| @@ -271,7 +271,7 @@ Sylvester.Matrix.prototype = { | |||
| if (!this.isSquare) { return null; } | |||
| var els = [], n = this.elements.length; | |||
There was a problem hiding this comment.
@zbjornson You know the length already in a lot these cases, you should use new Array(n) and then set the indexs x[i] = <val>
There was a problem hiding this comment.
@megawac that actually seems detrimental in some browsers and only a minor improvement in others: http://jsperf.com/construct-array-of-fixed-size/2
There was a problem hiding this comment.
(Specifically, I optimized for FF and chrome, and the gain in FF doesn't outweigh the loss in chrome.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building arrays via
arr[i] = xis ~45% faster thanarr.push(x). See http://jsperf.com/sylvesterloops/2Store references to mOrV.elements.
Inline loops instead of call out to map, which calls to forEach.