Skip to content

Commit

Permalink
Update test projects to .NET7 and update VerifyTests
Browse files Browse the repository at this point in the history
17.10.2 is that last version that doesn't use a forked newtonsoft.json
Also fixes a XUnit warning
  • Loading branch information
Bond-009 committed Sep 29, 2023
1 parent ca5766d commit 09965bc
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions TMDbLibTests/TMDbLibTests.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<Import Project="..\_Imports\Test.targets" />

<PropertyGroup>
<TargetFramework>net5.0</TargetFramework>
<TargetFramework>net7.0</TargetFramework>
</PropertyGroup>

<ItemGroup>
Expand All @@ -18,7 +18,7 @@
<PackageReference Include="xunit" Version="2.5.1" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.7.2" />
<PackageReference Include="xunit.runner.visualstudio" Version="2.5.1" PrivateAssets="All" />
<PackageReference Include="Verify.Xunit" Version="14.14.1" />
<PackageReference Include="Verify.Xunit" Version="17.10.2" />
</ItemGroup>

<ItemGroup>
Expand Down
4 changes: 2 additions & 2 deletions TMDbLibTests/UtilityTests/TaggedImageConverterTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,8 @@ public async Task TestJsonTaggedImageConverter(int personId)
else if (item.MediaType == MediaType.Season)
Assert.IsType<SearchTvSeason>(item.Media);
else
Assert.False(true, $"Unexpected type {item.GetType().Name}");
Assert.Fail($"Unexpected type {item.GetType().Name}");
});
}
}
}
}
2 changes: 1 addition & 1 deletion TestApplication/TestApplication.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<Import Project="..\_Imports\Test.targets" />

<PropertyGroup>
<TargetFramework>net5.0</TargetFramework>
<TargetFramework>net7.0</TargetFramework>
<OutputType>Exe</OutputType>
</PropertyGroup>

Expand Down

0 comments on commit 09965bc

Please sign in to comment.