Update the TargetFrameworks #459
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Targeting netstandard2.0 and net6.0 should be enough for the library as that should support all currently supported verions of .Net Framework (4.6.2+) and .NET (6.0+) while allowing it to compile on linux. (Technically .NET Framework 3.5 Service Pack 1 is still supported but we currently don't support that anyway) For the test projects I just went with the latest .NET version as .NET 5.0 isn't supported anymore.
|
We need to release 3.0.0 before this can go in. |
Gauvino
reviewed
Mar 15, 2024
| @@ -3,7 +3,7 @@ | |||
| <Import Project="..\_Imports\Test.targets" /> | |||
|
|
|||
| <PropertyGroup> | |||
| <TargetFramework>net5.0</TargetFramework> | |||
| <TargetFramework>net7.0</TargetFramework> | |||
There was a problem hiding this comment.
Suggested change
| <TargetFramework>net7.0</TargetFramework> | |
| <TargetFramework>net8.0</TargetFramework> |
| @@ -3,7 +3,7 @@ | |||
| <Import Project="..\_Imports\Test.targets" /> | |||
|
|
|||
| <PropertyGroup> | |||
| <TargetFramework>net5.0</TargetFramework> | |||
| <TargetFramework>net7.0</TargetFramework> | |||
There was a problem hiding this comment.
Suggested change
| <TargetFramework>net7.0</TargetFramework> | |
| <TargetFramework>net8.0</TargetFramework> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targeting netstandard2.0 and net6.0 should be enough for the library as that should support all currently supported verions of .Net Framework (4.6.2+) and .NET (6.0+) while allowing it to compile on linux.
(Technically .NET Framework 3.5 Service Pack 1 is still supported but we
currently don't support that anyway)
For the test projects I just went with the latest .NET version as .NET 5.0 isn't supported anymore.