lavc/videotoolbox: allow software fallback for all codecs #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyanmisaka
reviewed
Sep 8, 2024
|
In this case, which one is faster, the software fallback provided by Apple or the built-in decoder in ffmpeg? |
Apple disabled hardware decoding for some h264 files with certain condition and now ffmpeg will error out for such inputs because the software fallback is disabled. Allow software fallback for all codecs instead of only for HEVC to workaround this as the error handling outside ffmpeg would be harder. Allowing software fallback has no measurable performance impact when the hardware decoder is not overloaded.
gnattu
force-pushed
the
allow-vt-sw-decoder-fallback
branch
from
7188b99
to
4c8485a
Compare
Forget add that to the commit, re-pushed |
FFmpeg native is (much) faster in benchmark but there should not have impact on real world scenario because the VT sw decoder seems to be throttled as only two P cores are in use and each only have around 50% usage, while FFmpeg native used up all cores. |
nyanmisaka
approved these changes
Sep 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apple disabled hardware decoding for some h264 files with certain condition and now ffmpeg will error out for such inputs because the software fallback is disabled. Allow software fallback for all codecs instead of only for HEVC to workaround this as the error handling outside ffmpeg would be harder. Allowing software fallback has no measurable performance impact when the hardware decoder is not overloaded.
Refer: macOS 14.6 release note: https://developer.apple.com/documentation/macos-release-notes/macos-14_6-release-notes#Video-Toolbox
The impacted videos are rare but still exist.
Changes
Issues