fix(router): don't use replace on every route when going back #2464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cloudflare Pages deployment
|
ferferga
requested changes
Sep 17, 2024
There was a problem hiding this comment.
Thank you very much for your willingness to fix this! However, this doesn't fix the issue:
- This reintroduces the situation described in the comment: if you click on the link of the readme of this repo to load the hosted instance and then click in the back button, you will be redirected back to GitHub, while we want to hack all the back navigation inside the application (of course not in the browser's buttons, just in the app's).
- There's a reason why Vue Router has its own back function and we should not be more "clever". I believe this approach kills history routing and resolve hooks from Vue Router.
In either case, an appropiate fix would be to do nothing or perform the back on the logic truthiness, and only replace with index on falsyness. Can you try that and test if it fits all the conditions stated above?
ferferga
changed the title
ferferga
reviewed
Sep 18, 2024
ferferga
reviewed
Sep 18, 2024
ferferga
approved these changes
Sep 18, 2024
|
|
@ToastKiste21 Thank you very much for your contribution and finding that replace was the issue! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #2403
Summary
This merge request resolves a navigation issue where users were unable to traverse the entire navigation history using the back button in the application's sidebar. The problem stemmed from overriding the router.back method with router.replace, which disrupted the history stack and prevented Vue Router from accurately tracking the history length.