Added SortBy parameters to solve tracks appearing out of order #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Applies suggestion from #111 (comment) Partially solves issue #84 (Tracks appearing out of order)
|
Kudos, SonarCloud Quality Gate passed!
|
mcarlton00
approved these changes
Apr 16, 2022
There was a problem hiding this comment.
Code is fine. Thanks for contributing.
Like I mentioned in the issue, I wasn't seeing any significant change when I was doing this, and it seems like a lot of clients implement their own sorting. If you saw a change of behavior with this then I'll believe you. Either way, it won't hurt having it.
|
Thank you! in my experience 'MALP' and 'Iris' implement sorting, but 'muse' and 'musicbox_webclient' do not and are affected by this patch (I personally use 'musicbox_webclient' so I can confirm). Thank you for your great work on this plugin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies suggestion from #111 (comment)
Partially solves issue #84 (Tracks appearing out of order)
Tested using mopidy v3.2.0, works for the 'muse' and 'musicbox_webclient' web clients
First pull request in a public project! I apologize in advance if the quality is not the best