Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

try to add some info to the organizer guide #9

Merged
merged 4 commits into from
Sep 18, 2024
Merged

try to add some info to the organizer guide #9

merged 4 commits into from
Sep 18, 2024

Conversation

kweav
Copy link
Contributor

@kweav kweav commented Sep 12, 2024

Filled out the organizer guide a bit more with info on the goals and the schedule. Please leave suggestions for improvements!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 12, 2024 •
edited
Loading

No spelling errors! 🎉
Comment updated at 2024-09-18-17:31:25 with changes from f936885

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 12, 2024 •
edited
Loading

No broken url errors! 🎉
Comment updated at 2024-09-18-17:31:33 with changes from f936885

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 12, 2024 •
edited
Loading

Re-rendered previews from the latest commit:

* note not all html features will be properly displayed in the "quick preview" but it will give you a rough idea.

Updated at 2024-09-18 with changes from the latest commit f936885

avahoffman
avahoffman reviewed Sep 16, 2024
View reviewed changes
organizer-guide.Rmd Outdated Show resolved Hide resolved
avahoffman
avahoffman reviewed Sep 16, 2024
View reviewed changes
organizer-guide.Rmd Outdated Show resolved Hide resolved
avahoffman
avahoffman reviewed Sep 16, 2024
View reviewed changes
organizer-guide.Rmd Outdated Show resolved Hide resolved
avahoffman
avahoffman reviewed Sep 16, 2024
View reviewed changes
organizer-guide.Rmd Outdated Show resolved Hide resolved
avahoffman
avahoffman reviewed Sep 16, 2024
View reviewed changes
organizer-guide.Rmd Outdated Show resolved Hide resolved
avahoffman
avahoffman approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@avahoffman avahoffman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes suggested! I think a table would look nice - maybe a table for day 1 and a separate table for day 2?

Also need to address the spelling items in the dictionary.txt file.

@ehumph
Copy link
Contributor

ehumph commented Sep 16, 2024

@kweav sorry, I accidentally committed an edit instead of leaving it a suggestion. Feel free to revert.

LINE 10
Changed:

  • Build a community (inclusive to newcomers)

Now reads:

  • Build an inclusive community that is supportive of newcomers

LINE 12
Changed:

  • Report out a final product that accomplishes one of the following for a topic

Now reads:

  • Produce a final product that accomplishes one of the following for a topic

ehumph
ehumph reviewed Sep 16, 2024
View reviewed changes
organizer-guide.Rmd Outdated Show resolved Hide resolved
ehumph
ehumph approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@ehumph ehumph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good! Two minor suggestions that just tweak language

@avahoffman
Copy link
Contributor

Can we look into why the preview is not rendering correctly?

@avahoffman avahoffman mentioned this pull request Sep 16, 2024
Merged
@kweav
Copy link
Contributor Author

kweav commented Sep 16, 2024

@kweav sorry, I accidentally committed an edit instead of leaving it a suggestion. Feel free to revert.

LINE 10 Changed:

  • Build a community (inclusive to newcomers)

Now reads:

  • Build an inclusive community that is supportive of newcomers

LINE 12 Changed:

  • Report out a final product that accomplishes one of the following for a topic

Now reads:

  • Produce a final product that accomplishes one of the following for a topic

These look great! Thank you for making the edits!

@kweav
Copy link
Contributor Author

kweav commented Sep 16, 2024

Can we look into why the preview is not rendering correctly?

@avahoffman which preview are you referring to -- the quick preview website or comprehensive download? I see the download is a 404 error and it looks like the quick preview website is the un-updated information?

kweav
kweav commented Sep 16, 2024
View reviewed changes
organizer-guide.Rmd Outdated Show resolved Hide resolved
@kweav
Copy link
Contributor Author

kweav commented Sep 16, 2024 •
edited
Loading

Can we look into why the preview is not rendering correctly?

@avahoffman which preview are you referring to -- the quick preview website or comprehensive download? I see the download is a 404 error and it looks like the quick preview website is the un-updated information?

The quick preview works for me now: https://htmlpreview.github.io/?https://raw.githubusercontent.com/jhudsl/AnVIL_CoFests_2024/preview-9/docs/organizer-guide.html

As does the download

@ehumph
Copy link
Contributor

ehumph commented Sep 16, 2024

Can we look into why the preview is not rendering correctly?

@avahoffman which preview are you referring to -- the quick preview website or comprehensive download? I see the download is a 404 error and it looks like the quick preview website is the un-updated information?

The quick preview works for me now: https://htmlpreview.github.io/?https://raw.githubusercontent.com/jhudsl/AnVIL_CoFests_2024/preview-9/docs/organizer-guide.html

As does the download

The preview works for me as well (on both my laptop and on my phone).

@kweav
Copy link
Contributor Author

kweav commented Sep 16, 2024

@avahoffman and @ehumph just pushed a potential table setup

@avahoffman
Copy link
Contributor

Can we look into why the preview is not rendering correctly?

@avahoffman which preview are you referring to -- the quick preview website or comprehensive download? I see the download is a 404 error and it looks like the quick preview website is the un-updated information?

Yes that's what I was referring to - looks correct now!

@avahoffman
Copy link
Contributor

@avahoffman and @ehumph just pushed a potential table setup

Sweet, thank you! After seeing it, I'm thinking it looks a little cluttered in table form. Maybe we go back to what we had. So sorry for the extra work!

avahoffman
avahoffman reviewed Sep 16, 2024
View reviewed changes
organizer-guide.Rmd Outdated Show resolved Hide resolved
avahoffman
avahoffman reviewed Sep 16, 2024
View reviewed changes
organizer-guide.Rmd Outdated Show resolved Hide resolved
avahoffman
avahoffman reviewed Sep 16, 2024
View reviewed changes
organizer-guide.Rmd Outdated Show resolved Hide resolved
javibio-git
javibio-git reviewed Sep 16, 2024
View reviewed changes
organizer-guide.Rmd Outdated Show resolved Hide resolved
organizer-guide.Rmd Outdated Show resolved Hide resolved
organizer-guide.Rmd Outdated Show resolved Hide resolved
javibio-git
javibio-git reviewed Sep 16, 2024
View reviewed changes
organizer-guide.Rmd Outdated Show resolved Hide resolved
@kweav
Copy link
Contributor Author

kweav commented Sep 16, 2024

Minor changes suggested! I think a table would look nice - maybe a table for day 1 and a separate table for day 2?

Also need to address the spelling items in the dictionary.txt file.

@avahoffman spell check should be addressed as of commit 2c24440

@avahoffman avahoffman mentioned this pull request Sep 18, 2024
Merged
@kweav
Copy link
Contributor Author

kweav commented Sep 18, 2024

@avahoffman and @ehumph just pushed a potential table setup

Sweet, thank you! After seeing it, I'm thinking it looks a little cluttered in table form. Maybe we go back to what we had. So sorry for the extra work!

I really like the edits to the table you made in PR #11 so leaving them in this one as is, knowing they've been addressed there -- thank you!

avahoffman
avahoffman reviewed Sep 18, 2024
View reviewed changes
organizer-guide.Rmd Outdated Show resolved Hide resolved
kweav
kweav commented Sep 18, 2024
View reviewed changes
organizer-guide.Rmd Outdated Show resolved Hide resolved
@kweav kweav merged commit 147a778 into main Sep 18, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javibio-git javibio-git javibio-git left review comments

@avahoffman avahoffman avahoffman approved these changes

@ehumph ehumph ehumph approved these changes

@cutsort cutsort Awaiting requested review from cutsort

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kweav @ehumph @avahoffman @javibio-git