Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: kysely 적용 #670

Merged
merged 5 commits into from
Aug 24, 2023
Merged

feat: kysely 적용 #670

merged 5 commits into from
Aug 24, 2023

Conversation

scarf005
Copy link
Member

@scarf005 scarf005 commented Aug 13, 2023

개요

image

https://github.com/orgs/jiphyeonjeon-42/discussions/9#discussioncomment-6677350

작업 사항

변경점

  • ts-rest 버전 업데이트
  • v2/reviews에서 kysely 사용

목적

raw query를 타입 안전하게 변경

@scarf005 scarf005 added the blocked 다른 PR에 의존중 label Aug 13, 2023
@scarf005 scarf005 marked this pull request as draft August 13, 2023 13:20
@scarf005 scarf005 removed the blocked 다른 PR에 의존중 label Aug 14, 2023
@scarf005 scarf005 self-assigned this Aug 21, 2023
@scarf005 scarf005 temporarily deployed to development August 24, 2023 04:36 — with GitHub Actions Inactive
Copy link
Contributor

@JeongJiHwan JeongJiHwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typeorm 에서 kysely로 변경되는 내용들 확인했습니다.

@scarf005 scarf005 changed the title feat(wip): kysely 적용 feat: kysely 적용 Aug 24, 2023
@scarf005 scarf005 merged commit 7c57107 into develop Aug 24, 2023
5 checks passed
@scarf005 scarf005 deleted the kysely branch August 24, 2023 04:49
JeongJiHwan pushed a commit that referenced this pull request Aug 25, 2023
* build: ts-rest와 zod 버전 업데이트

* build: kysely 추가

* feat: db 타입 생성 및 kysely 연결

* feat: 타입 안전한 date 함수 래퍼

* refactor: `v2/reviews`에 kysely 적용

---------

Co-authored-by: nocontribute <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 완료
Development

Successfully merging this pull request may close these issues.

2 participants