Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 책 등록 시 책 검색용 키워드 저장 #727

Merged
merged 3 commits into from
Sep 1, 2023
Merged

feat: 책 등록 시 책 검색용 키워드 저장 #727

merged 3 commits into from
Sep 1, 2023

Conversation

Jiwon-Woo
Copy link
Member

@Jiwon-Woo Jiwon-Woo commented Sep 1, 2023 •
edited
Loading

개요

작업 사항

  • bookInfoSearchKeyword 엔티티, 리포지토리, createBookInfoSearchKeyword create 함수 추가
  • 책 등록하는 트랜젝션에 createBookInfoSearchKeyword 함수 추가

변경점

  • 책을 등록할 때 책 검색용 키워드도 함께 저장되는 로직이 추가 되었습니다.
  • 책을 등록하는 로직이 이미 트랜잭션 처리 되고 있었고, typeORM을 사용하고 있었기 때문에, bookInfoSearchKeyword도 같은 방식으로 처리할 수 있도록 만들었습니다.

목적

  • 책을 등록하는 동시에 bookInfoSearchKeyword를 저장하여 bookInfoSearchKeyword를 별도로 저장할 필요없게 만듭니다.

@Jiwon-Woo Jiwon-Woo added the enhancement New feature or request label Sep 1, 2023
@Jiwon-Woo Jiwon-Woo self-assigned this Sep 1, 2023
@Jiwon-Woo Jiwon-Woo temporarily deployed to development September 1, 2023 17:06 — with GitHub Actions Inactive
@Jiwon-Woo Jiwon-Woo changed the title 726 책 등록 시 책 검색용 키워드 저장 feat: 책 등록 시 책 검색용 키워드 저장 Sep 1, 2023
@Jiwon-Woo Jiwon-Woo linked an issue Sep 1, 2023 that may be closed by this pull request
책 등록 시 책 검색용 키워드 저장 #726
Closed
nyj001012
nyj001012 approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@nyj001012 nyj001012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jiwon-Woo Jiwon-Woo merged commit fd50832 into develop Sep 1, 2023
5 checks passed
@Jiwon-Woo Jiwon-Woo deleted the 726-책-등록-시-책-검색용-키워드-저장 branch September 1, 2023 18:19
@Jiwon-Woo Jiwon-Woo linked an issue Sep 1, 2023 that may be closed by this pull request
☂️ 검색 기능 고도화를 위한 v1 API 수정 #715
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nyj001012 nyj001012 nyj001012 approved these changes

@Jake1152 Jake1152 Awaiting requested review from Jake1152

Assignees

@Jiwon-Woo Jiwon-Woo

Labels
enhancement New feature or request
Projects
집현전 검색 기능 TF팀
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

책 등록 시 책 검색용 키워드 저장 ☂️ 검색 기능 고도화를 위한 v1 API 수정
2 participants
@Jiwon-Woo @nyj001012