Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 특수문자 제거 시 분해된 한글이 제거되지 않도록 수정 #757

Merged
merged 3 commits into from
Sep 7, 2023
Merged

fix: 특수문자 제거 시 분해된 한글이 제거되지 않도록 수정 #757

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2adca81
fix: 자모 분해하기 전 특수문자 제거
Jiwon-Woo Sep 6, 2023
edfe293
refactor: 자모 분해하기 전 특수문자 제거 대신 정규식 수정
Jiwon-Woo Sep 6, 2023
a944821
fix: like 검색 시 홑따옴표 제외
Jiwon-Woo Sep 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion backend/src/v1/books/books.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ export const searchInfo = async (
const disassemble = query ? disassembleHangul(query) : '';
const initials = query ? extractHangulInitials(query) : '';
const fullTextSearch = removeSpecialCharacters(disassemble);
const likeSearch = disassemble.replaceAll(' ', '%').replaceAll(' ', '%');
const likeSearch = disassemble.replaceAll("'", '').replaceAll(' ', '%');

let matchScore: string;
let searchCondition: string;
Expand Down
10 changes: 5 additions & 5 deletions backend/src/v1/search-keywords/searchKeywords.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,15 +164,15 @@ export const createSearchKeywordLog = async (

export const getSearchAutocompletePreviewResult = async (keyword: string) => {
const LIMIT_OF_SEARCH_KEYWORD_PREVIEW = 12;
let keywordInitials = extractHangulInitials(keyword as string);
let disassembledKeyword = extractHangulInitials(keyword as string);
let isCho = true;

if (keyword !== keywordInitials) {
keywordInitials = disassembleHangul(keyword as string);
if (keyword !== disassembledKeyword) {
disassembledKeyword = disassembleHangul(keyword as string);
isCho = false;
}
const fullTextSearch = removeSpecialCharacters(keywordInitials);
const likeSearch = keywordInitials.replaceAll(' ', '%').replaceAll(' ', '%');
const fullTextSearch = removeSpecialCharacters(disassembledKeyword);
const likeSearch = disassembledKeyword.replaceAll("'", '').replaceAll(' ', '%');

let queryResult: AutocompleteKeyword[] = [];
let totalCount: number;
Expand Down
2 changes: 1 addition & 1 deletion backend/src/v1/utils/processKeywords.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,6 @@ export const extractHangulInitials = (original: string | undefined) => {
};

export const removeSpecialCharacters = (input: string) => {
const regex = /[^a-zA-Z0-9가-힣\s]/g;
const regex = /[^a-zA-Z0-9가-힣ㄱ-ㅎㅏ-ㅣ\s]/g;
return input.replace(regex, '');
};
Loading