-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
develop to main #607
Merged
develop to main #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. 변수명 변경 "userCate" 같은 모호한 표현 대신 selectedCategory 등으로 명시 2. DOM 접근방식 개선 querySelector -> useRef 3. 복잡한 for문의 합계 대신 array filter 및 getBoundingClientRect를 활용
* feat: recoil `localStorageEffect` * refactor: `userState` -> `userAtom` 및 localStorageEffect 적용 * refactor: useGetAuthMe에 userAtom 적용 * refactor: useGetReviewInfo에 userAtom 적용 * refactor: PostReview에 userAtom 적용 * refactor: Tag에 userAtom 적용 * refactor: ELibraryHeader에 적용 * refactor: Logout에 localStorageEffect 적용 * refactor: MyRent에 userIdAtom 적용 * refactor: editEmail에 userAtom 적용 * refactor: Mypage에 userIdAtom 적용 * refactor: MyReservation에 userIdAtom 적용 * refactor: HandleReview userAtom 적용 * refactor: HeaderDefault에 isUserAuthedAtom 적용 * refactor: HeaderDefaultLNB에 userAtom 적용 * refactor: HeaderModal에 userAtom 적용 * refactor: usePermission에 userAtom 적용 * feat: App 인증 로직에 recoil localStorageEffect 적용 * refactor: LimitedRoute에 userAtom 적용
not yet implemented
feat: error cat
chore: 불필요한 index.css 제거
fix: 센트리가 제대로 동작하지 않는 문제 수정
not-using
approved these changes
Feb 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
배포