fix(application) wait for application to be destroyed #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When destroying an application, wait for it to be destroyed before returning. Issue juju#521 and maybe others. Otherwise terraform fails when RequireReplace is set.
Replace ProcessErrorResults with errors.Join which does the same thing for us.
Two versions of the juju/names pacakge were directly used. Luckily there was no conflict. Move to the most recent.
anvial
reviewed
Jul 12, 2024
| @@ -22,7 +22,6 @@ require ( | |||
| github.com/juju/cmd/v3 v3.0.14 | |||
| github.com/juju/collections v1.0.4 | |||
| github.com/juju/errors v1.0.0 | |||
| github.com/juju/names/v4 v4.0.0-20220207005702-9c6532a52823 | |||
There was a problem hiding this comment.
Looks like we mistakenly started using names/v4 instead v5 somewhere. I think we need to use just v5
| @@ -24,7 +24,7 @@ import ( | |||
| "github.com/hashicorp/terraform-plugin-framework/types" | |||
| "github.com/hashicorp/terraform-plugin-log/tflog" | |||
| "github.com/juju/juju/core/constraints" | |||
| "github.com/juju/names/v4" | |||
| "github.com/juju/names/v5" | |||
There was a problem hiding this comment.
we need to make these changes in every resource. (v4 --> v5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Wait for an application to actually be destroyed when calling Destroy(). This is an issue where terraform is calling Destroy() then Create() when the former completes. Juju may not have had time to fully destroy the application before we try to recreate it.
A bit of refactoring to put errors in the same place and use errors.Join() rather than a home grown version.
Stop using 2 versions of the juju/names package, only one should be.
Fixes: 521
Type of change
QA steps
Manual QA steps should be done to test this PR.
Use juju status to see the application running. Then edit the plan to change storage_directive from
2Gto1Gand re-run the plan.Additional notes
JUJU-6348