Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quantum state discrimination tutorial #3250

Merged
merged 8 commits into from
Mar 1, 2023
Merged

Conversation

odow
Copy link
Member

@odow odow commented Feb 27, 2023

x-ref #2348 (comment)

Also fixes #3245 (comment)

Still a WIP, because I don't really know enough physics to write about the problem we're solving, or what the solution represents.

Preview: https://jump.dev/JuMP.jl/previews/PR3250/tutorials/conic/quantum_discrimination/

@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (6329762) 98.09% compared to head (b2dd210) 98.09%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3250   +/-   ##
=======================================
  Coverage   98.09%   98.09%           
=======================================
  Files          34       34           
  Lines        4663     4664    +1     
=======================================
+ Hits         4574     4575    +1     
  Misses         89       89           
Impacted Files Coverage Δ
src/macros.jl 98.57% <0.00%> (+<0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@odow odow changed the title WIP: Add quantum state discrimination tutorial Add quantum state discrimination tutorial Feb 28, 2023
Copy link
Collaborator

@jd-foster jd-foster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A POVM is the set of PSD matrices over the states 1:N, not the individual matrices.

docs/src/tutorials/conic/quantum_discrimination.jl Outdated Show resolved Hide resolved
docs/src/tutorials/conic/quantum_discrimination.jl Outdated Show resolved Hide resolved
docs/src/tutorials/conic/quantum_discrimination.jl Outdated Show resolved Hide resolved
docs/src/tutorials/conic/quantum_discrimination.jl Outdated Show resolved Hide resolved
docs/styles/Vocab/JuMP-Vocab/accept.txt Outdated Show resolved Hide resolved
@jd-foster
Copy link
Collaborator

This all looks great to me. My only last question is whether you wanted to seed the random generation?

@odow
Copy link
Member Author

odow commented Feb 28, 2023

My only last question is whether you wanted to seed the random generation?

Nah. It'll be okay.

@araujoms
Copy link
Contributor

The task is the following: you are given an unknown quantum state, promised to come from a known set of n states (sampled with uniform probability, for simplicity). You need to find out which quantum state it is. The objective of the SDP is the probability of success, \sum_i p( guess i| state i)/n. The matrices E[i] are the POVM elements, encoding the optimal measurement you can do.

@araujoms
Copy link
Contributor

More specific comments: one is interested in the value of the objective, not on the POVM elements, so I'd print the objective instead. Also, in the problem formulation I'd write the objective as \sum_i \operatorname{tr}(\rho_i E_i)/N instead of \mathbb{E}_i[ \operatorname{tr}(\rho_i E_i)].

Also worth remarking is that for N=2 the problem is trivial, with solution given by 0.5 + 0.25*sum(svdvals(rho[1]-rho[2])).

@ericphanson
Copy link
Contributor

In case it’s helpful, I have an example written with Convex.jl here, where I compare to the analytic solution for a simple example

@odow
Copy link
Member Author

odow commented Feb 28, 2023

Updated with @araujoms suggestions. I don't know if we need to go into detail about the theory behind the model. People interested in HermitianPSDCone will probably already have the necessary background.

@odow
Copy link
Member Author

odow commented Mar 1, 2023

Merging since we seem to have converged on this. Any other changes can happen in a new PR.

@odow odow merged commit 60392b0 into master Mar 1, 2023
@odow odow deleted the od/quantum_discrimination branch March 1, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants