Add upper_triangle and docs for {Log,Root}DetCone{Triangle,Square} #3456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
It could also be the lower triangle row wise. Maybe simply |
odow
force-pushed
the
od/upper-triangle
branch
from
0d1f7a7
to
9224fde
Compare
odow
force-pushed
the
od/upper-triangle
branch
from
9224fde
to
3c4cad1
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3456 +/- ##
==========================================
+ Coverage 97.99% 98.00% +0.01%
==========================================
Files 36 36
Lines 5043 5069 +26
==========================================
+ Hits 4942 4968 +26
Misses 101 101
☔ View full report in Codecov by Sentry. |
odow
commented
Aug 25, 2023
mlubin
approved these changes
Aug 25, 2023
blegat
reviewed
Aug 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacement for #3427