[Bridges] mark ScalarQuadraticToScalarNonlinearBridge as experimental #2249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We could also do a v1.18.1 with cherry picked fixes that we want to release |
|
I don't like cherry-picked releases. We're not trying to conserve version numbers, so let's not add more complications. |
|
Closing because we should make a decision on #2235 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2232 has been sitting open for too long. It is blocked by #2235, which would remove this bridge. If we tagged 1.19 before #2235, then removing it would be breaking. So I've opted to leave the code in for now, but not add it by default.
That should let us release v1.19 and take a longer look at #2235.