Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix assumption about variable ordering in tests #69

Merged
merged 2 commits into from
Jun 13, 2024
Merged

Fix assumption about variable ordering in tests #69

merged 2 commits into from
Jun 13, 2024

Conversation

odow
Copy link
Member

@odow odow commented Jun 12, 2024

jump-dev/MathOptInterface.jl#2495 may change the ordering of variables. The current behavior is an implementation detail, so we can make these tests more robust regardless.

Copy link

codecov bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.48%. Comparing base (94ccee7) to head (0877efe).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #69   +/-   ##
=======================================
  Coverage   97.48%   97.48%           
=======================================
  Files           3        3           
  Lines         477      477           
=======================================
  Hits          465      465           
  Misses         12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@odow odow merged commit d8ef5d2 into master Jun 13, 2024
7 checks passed
@odow odow deleted the od/fix-test branch June 13, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant