Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "builtin cd" instead of just "cd" #92

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use "builtin cd" instead of just "cd" #92

wants to merge 1 commit into from

Conversation

andsild
Copy link

@andsild andsild commented May 10, 2019

Similar to #68

In case someone has overloaded the "cd" command (with alias), the
plugin's behaviour can be odd. E.g. if a cd alias also types in "ls"
after "cd", the autocompletion will spew out directory contents each
time user hits tab.

This MR amends said problem by ensuring cd is default version.

Similar to #68

In case someone has overloaded the "cd" command (with alias), the
plugin's behaviour can be odd. E.g. if a cd alias also types in "ls"
after "cd", the autocompletion will spew out directory contents each
time user hits tab.
@mosabua
Copy link
Collaborator

mosabua commented Apr 21, 2020

Does this work for the supported shells?

@glhez
Copy link

glhez commented May 2, 2020

What are the supported shells?

Given the name of the project, file and so, I would assume it is "bash".
If not, then you perhaps you should update the README.md to indicate what is supported.

builtin and cd are indeed bash builtin (sorry, there are no direct link the exact location)

  1. cd
  2. builtin

By the way my PR#68 should have used the command builtin which is clearly more obvious than \.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants