Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport release-1.28] fix(helm): error gets removed from chart cr on subsequent reconciles #4976

Merged
merged 1 commit into from
Sep 16, 2024
Merged

[Backport release-1.28] fix(helm): error gets removed from chart cr on subsequent reconciles #4976

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 14 additions & 13 deletions pkg/component/controller/extensions_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,19 +322,20 @@ func (cr *ChartReconciler) updateOrInstallChart(ctx context.Context, chart helmv
return fmt.Errorf("can't reconcile installation for %q: %w", chart.GetName(), err)
}
} else {
if cr.chartNeedsUpgrade(chart) {
// update
chartRelease, err = cr.helm.UpgradeChart(ctx,
chart.Spec.ChartName,
chart.Spec.Version,
chart.Status.ReleaseName,
chart.Status.Namespace,
chart.Spec.YamlValues(),
timeout,
)
if err != nil {
return fmt.Errorf("can't reconcile upgrade for %q: %w", chart.GetName(), err)
}
if !cr.chartNeedsUpgrade(chart) {
return nil
}
// update
chartRelease, err = cr.helm.UpgradeChart(ctx,
chart.Spec.ChartName,
chart.Spec.Version,
chart.Status.ReleaseName,
chart.Status.Namespace,
chart.Spec.YamlValues(),
timeout,
)
if err != nil {
return fmt.Errorf("can't reconcile upgrade for %q: %w", chart.GetName(), err)
}
}
if err := apiretry.RetryOnConflict(apiretry.DefaultRetry, func() error {
Expand Down
Loading