[Backport release-1.30] Move generated CRDs into their own directory #4985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce the static/_crds/* directories, which replace the static/manifests/*/CustomResourceDefinition directories. The underscore in the name prevents go tools from descending into the folder when looking for go files. This makes it safe to run go commands at the same time as generating the CRDs in this folder. This prevents errors like the following: go: finding module for package github.com/k0sproject/k0s/static/manifests/v1beta1/CustomResourceDefinition go: finding module for package github.com/k0sproject/k0s/static/manifests/helm/CustomResourceDefinition go: finding module for package github.com/k0sproject/k0s/static/manifests/autopilot/CustomResourceDefinition go: finding module for package github.com/k0sproject/k0s/static/manifests/etcd/CustomResourceDefinition go: github.com/k0sproject/k0s/static/manifests/autopilot/CustomResourceDefinition: no matching versions for query "latest" go: github.com/k0sproject/k0s/static/manifests/etcd/CustomResourceDefinition: no matching versions for query "latest" go: github.com/k0sproject/k0s/static/manifests/helm/CustomResourceDefinition: no matching versions for query "latest" go: github.com/k0sproject/k0s/static/manifests/v1beta1/CustomResourceDefinition: no matching versions for query "latest" make: *** [Makefile:113: go.sum] Error 1 Signed-off-by: Tom Wieczorek <[email protected]> (cherry picked from commit 583cf5d)
ncopa
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport to
release-1.30:This backport makes the CI for Windows unit tests much less flaky.