Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make helm timeout backward compatible #5017

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ricardomaraschini
Copy link
Contributor

@ricardomaraschini ricardomaraschini commented Sep 19, 2024

Description

in the past the helm chart install timeout was moved from an integer to a string. this commit brings back the capability of using integers to set the helm chart timeout.

Type of change

  • Chore
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

in the past the helm chart install timeout was moved from an integer to
a string. this commit brings back the capability of using integers to
set the helm chart timeout.

Signed-off-by: Ricardo Maraschini <[email protected]>
@twz123
Copy link
Member

twz123 commented Sep 19, 2024

Breaking the API was a deliberate decision back in the day. Maybe the old assessment is no longer valid?

@ricardomaraschini
Copy link
Contributor Author

Breaking the API was a deliberate decision back in the day. Maybe the old assessment is no longer valid?

We have been using the old API (timeout as integers) to allow users to set up timeouts for their helm charts. This breaking change without a correspondent CRD version change really broke our legs :-( I was trying to see how hard it would be to make this work with both integers and strings but it seems more complex than I anticipated.

@ricardomaraschini ricardomaraschini marked this pull request as ready for review September 19, 2024 20:52
@ricardomaraschini ricardomaraschini requested a review from a team as a code owner September 19, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants