Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Have renovate manage image versions in Earthfile #841

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

sdwilsh
Copy link
Contributor

@sdwilsh sdwilsh commented Feb 8, 2023

What this PR does / why we need it:
This change adds support for renovate to be able to update the versions of quay.io/luet/base, golang, and hadolint.

Tested with:

  • docker run --mount type=bind,source=$(pwd)/renovate.json,target=/usr/src/app/renovate.json -it renovate/renovate renovate-config-validator
  • https://regex101.com/r/Ax3iG9/1

@netlify
Copy link

netlify bot commented Feb 8, 2023

Deploy Preview for kairos-io canceled.

Name Link
🔨 Latest commit c42e324
🔍 Latest deploy log https://app.netlify.com/sites/kairos-io/deploys/63e326df4ff9bf0007d1eaa0

This change adds support for renovate to be able to update the versions
of `quay.io/luet/base`, `golang`, and `hadolint`.

Signed-off-by: Shawn Wilsher <[email protected]>
@sdwilsh sdwilsh marked this pull request as ready for review February 8, 2023 04:38
Copy link
Member

@mauromorales mauromorales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fancy! LGTM

For the Go version I think we will most likely have to close until all dependencies are working well with 1.19 but that's ok

@mudler mudler merged commit e1c17d2 into kairos-io:master Feb 8, 2023
@mudler
Copy link
Member

mudler commented Feb 8, 2023

loving it! thanks @sdwilsh !

@Itxaka
Copy link
Member

Itxaka commented Feb 8, 2023

pretty cool, stealing this for other places :)

@sdwilsh
Copy link
Contributor Author

sdwilsh commented Feb 8, 2023

Looking at #310, it doesn't look like renovate has noticed this change, or it isn't working. Annoyingly, they don't have a way to test this really, as far as I could tell from the docs.

@sdwilsh
Copy link
Contributor Author

sdwilsh commented Feb 8, 2023

We might want to change the fileMatch entry to better match the regular expression they use for docker files, so it'd look something like this instead of what I used here: (^|/|\\.)Earthfile$. It's also possible that it just hasn't run to pick up the changes yet, but I don't see that configured in the repository (it might be configured at the org level). I'll give it some time to see if it gets picked up, and if not, we'll have to play with the config more.

@sdwilsh sdwilsh deleted the renovate-add-earthfile branch February 8, 2023 20:00
@sdwilsh
Copy link
Contributor Author

sdwilsh commented Feb 8, 2023

I was wrong; this is working, but it's under regex, not docker:
image

So this is working :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants