Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Add docker versioning for the RENOVATE_VERSION #863

Merged
merged 1 commit into from
Feb 10, 2023

Conversation

sdwilsh
Copy link
Contributor

@sdwilsh sdwilsh commented Feb 10, 2023

What this PR does / why we need it:
This isn't being picked up in the dashboard (#310), and it might be because 34 isn't a proper semver.

This isn't being picked up in the dashboard (kairos-io#310), and it might be
because `34` isn't a proper semver.

Signed-off-by: Shawn Wilsher <[email protected]>
@netlify
Copy link

netlify bot commented Feb 10, 2023

Deploy Preview for kairos-io canceled.

Name Link
🔨 Latest commit 01d6567
🔍 Latest deploy log https://app.netlify.com/sites/kairos-io/deploys/63e5c286fa38a70008b33c0f

@codecov-commenter
Copy link

Codecov Report

Merging #863 (01d6567) into master (17ce2b8) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##           master     #863   +/-   ##
=======================================
  Coverage   21.60%   21.60%           
=======================================
  Files          21       21           
  Lines        1523     1523           
=======================================
  Hits          329      329           
  Misses       1142     1142           
  Partials       52       52           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sdwilsh sdwilsh changed the title Add docker versioning for the RENOVATE_VERSION 🔧 Add docker versioning for the RENOVATE_VERSION Feb 10, 2023
Copy link
Member

@mauromorales mauromorales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mauromorales mauromorales merged commit 438d5ea into kairos-io:master Feb 10, 2023
@sdwilsh
Copy link
Contributor Author

sdwilsh commented Feb 10, 2023

This showed up after the merge in the dashboard, so this was the issue!

@sdwilsh sdwilsh deleted the renovate-version branch February 10, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants