Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for optimistic alignment to PeriodSnapshot.accumulator #812

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

perenecabuto
Copy link

This change adds support to PeriodSnapshot.Accumulator to do not align tickers when kamon.metric.optimistic-tick-alignment is disabled.

Motivation:
Here in my team we use Kamon in many projects and we use accumulators to have different metric ticker times.
As we have very heavy metrics load sent to our metrics DB and our API server has many units,
it uses an entropy strategy to do not send all the messages at the same time from all the units.
So we disable kamon.metric.optimistic-tick-alignment and start Kamon with a random delay and expect that the accumulators respect this policy.

@perenecabuto
Copy link
Author

Hello, @dpsoft.

Do you have any plans to merge this PR and release it? I've made a private fork, so I'd like to remove it and use the official Kamon.

Best,
Felipe.,

@perenecabuto perenecabuto force-pushed the feature/add-support-to-optimistic-alignment-to-accumulator branch from bc33b1d to 6fc3663 Compare February 4, 2021 19:13
@perenecabuto perenecabuto force-pushed the feature/add-support-to-optimistic-alignment-to-accumulator branch from 6fc3663 to e62848a Compare February 12, 2021 12:56
@perenecabuto perenecabuto force-pushed the feature/add-support-to-optimistic-alignment-to-accumulator branch from e62848a to 8b54aba Compare February 12, 2021 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant