Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative C# implementation #613

Open
wants to merge 24 commits into
base: master
Choose a base branch
from

Conversation

dfuenzalida
Copy link
Contributor

Hi!

This is an alternative implementation of MAL in C# using the .NET Core SDK 6.0 which has Long Term Support.

Copy link
Owner

@kanaka kanaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @dfuenzalida sorry for the very slow reply (I've been unable to work on this project for the past couple of years but I'm am now able to again). If you're still interested in getting this merged upstream I would ask that you do the following:

  • Rebase the code onto the current HEAD
  • Add to the implementation description section of the README explaining how to use your implementation and what makes it different from the existing c# impl.
  • The recommended process has changed slightly: the eval_ast is no longer seperate from eval and macroexpand is not longer a standalone function. It would be good if you could update to follow the new structure.
  • Make sure that the Github CI tests all pass for your implementation. By rebasing you will pick up improvements to the CI process that no longer require me to manually build/push a docker image.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants