Added types for typescript #2022
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you want get it merged, please update it against the current master. There are 3 new methods and remove the .idea-entry in .gitignore. This have nothing to do with this pr. |
| local: { | ||
| hasPermission(callback?: Function, scope?: Object): void; | ||
| requestPermission(callback?: Function, scope?: Object): void; | ||
| schedule(notifications: LocalNotification[], callback?: Function, scope?: Object): void; |
There was a problem hiding this comment.
The schedule function allows you to input a single object (with out a list)
cordova.plugins.notification.local.schedule({
title: 'My first notification',
text: 'Thats pretty easy...',
foreground: true
});
Therefor the typing should be something like this
schedule(notifications: LocalNotification | LocalNotification[], callback?: Function, scope?: Object): void;
| summary?: string | null; | ||
| text?: string; | ||
| title?: string; | ||
| trigger?: { |
There was a problem hiding this comment.
When using trigger like this
cordova.plugins.notification.local.schedule({
title: 'Design team meeting',
trigger: { in: 1, unit: 'hour' }
});
The "at" and "every" property should be optional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added an
index.d.tsfile so that you can use it in typescript. One really could use it if they are making their interface in angular