revert: bring back gtm #423
Conversation
|
✔️ Deploy Preview for wargabantuwarga ready! 🔨 Explore the source changes: fd7d215 🔍 Inspect the deploy log: https://app.netlify.com/sites/wargabantuwarga/deploys/60fdbaea1441480007880128 😎 Browse the preview: https://deploy-preview-423--wargabantuwarga.netlify.app |
Codecov Report
@@ Coverage Diff @@
## main #423 +/- ##
=======================================
Coverage 29.56% 29.56%
=======================================
Files 67 67
Lines 866 866
Branches 258 258
=======================================
Hits 256 256
Misses 605 605
Partials 5 5
Continue to review full report at Codecov.
|
|
Is this something that we can add unit test to? Just to make sure similar issue less likely happening in the future? @mazipan |
|
I think we can cover this case by our automated testing. Since this is a high priority bug, we need to deliver the fix as fast as we can. |
|
Create #425 for the testing part |
There was a problem hiding this comment.
Just some concern about this mas @mazipan @zainfathoni
Need to make sure that the noscript is also present on the body, currently, when loading the web, it seems that there's no noscript present when I check the source code.
| @@ -82,6 +83,25 @@ export default function App({ Component, pageProps, router }: AppProps) { | |||
| <link href="/manifest.json" rel="manifest" /> | |||
| <meta content="#1667C2" name="theme-color" /> | |||
| </Head> | |||
|
|
|||
There was a problem hiding this comment.
This line 86 could be removed I think
| style={{ display: "none", visibility: "hidden" }} | ||
| title="gtm" | ||
| width="0" | ||
| /> |
There was a problem hiding this comment.
need to add </iframe> instead for the noscript to work properly.
See previous implementation here: https://github.com/kawalcovid19/wargabantuwarga.com/pull/36/files?file-filters%5B%5D=.tsx
There was a problem hiding this comment.
Bisa insert expectation kode komplit nya dari GTM gak ya, Mas @baraeb92.?
There was a problem hiding this comment.
Since all these codes are just copy-paste from previous implementation without any modifications
There was a problem hiding this comment.
It already exist, it just under main tag, should we move it under body?
Closes #419
Description
Based on this PR #320, I revert the changes about GTM, move it to the top level
Current Tasks
index.tsxwith thehome-page.tsxfile #320home-page.tsx