Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(KcAccountUiLoader.tsx): authUrl can be a string #3

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

jspizziri
Copy link
Contributor

there are cases in which authUrl can be a string. In these cases the serverBaseUrl currently throws because authUrl.rawSchemeSpecificPart is undefined and therefore authUrl.rawSchemeSpecificPart.replace is an invalid access.

there are cases in which `authUrl` can be a string. In these cases the `serverBaseUrl` currently throws because `authUrl.rawSchemeSpecificPart` is `undefined` and therefore `authUrl.rawSchemeSpecificPart.replace` is an invalid access.
@jspizziri
Copy link
Contributor Author

@garronej just an FYI on this. This is causing issues on keycloak 21.1 when a Frontend Url is set.

@garronej
Copy link
Contributor

Very nice thank you very much!

@garronej garronej merged commit b1f367e into keycloakify:main Sep 19, 2024
1 check failed
@jspizziri
Copy link
Contributor Author

Thanks for the merge! Any general thoughts on when this might be released?

@garronej
Copy link
Contributor

I just did 25.0.4-rc.6

@jspizziri
Copy link
Contributor Author

thank you sir!

@garronej
Copy link
Contributor

NOTE: In the context of this package rc.6 does not mean release candidate. It's just an aditional version number that I use to version the compatibility layer code while still matching the version of the source package.

@jspizziri
Copy link
Contributor Author

I'm also seeing some strange things happening with i18n when there's a Frontend URL. I'll try to look into it next week.

@garronej
Copy link
Contributor

Thank very much, @jspizziri!
Your feedback is very helpful.

Just to clarify, as you likely understood, this package provides a compatibility layer, allowing the original package—designed specifically for Keycloak 25—to work with both older and future versions of Keycloak.

To achieve this, I infer the running Keycloak version based on the structure of the FreeMarker context and adapt (or polyfill) the API calls accordingly.

The approach I've taken is quite empirical, so there may still be some mistake here and there as you are experiencing. It's invaluable to get a hand from developers like you, who are deploying custom Account UIs on older Keycloak versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants