-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New light Docker image for serverless deployment #152
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Pierre-Alexandre Meyer <[email protected]>
Signed-off-by: Pierre-Alexandre Meyer <[email protected]>
Signed-off-by: Pierre-Alexandre Meyer <[email protected]>
@@ -0,0 +1,14 @@ | |||
org.killbill.security.shiroNbHashIterations=1 | |||
org.killbill.jaxrs.threads.pool.nb=5 | |||
org.killbill.payment.plugin.threads.nb=1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are going from one extreme to the next :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, for serverless deployments, the payment integration doesn't really work out of the box:
- Ruby plugins are too memory hungry
- OSS Java payment plugins are for gateways which require IP source whitelisting (unpredictable)
It's really a subscription-only profile which should be deployed :-)
1b7d32c
to
b6604cd
Compare
This light image can be deployed in serverless environments (e.g. Google Cloud Run). Among differences with the main image:
killbill.properties
as Ansible won't work without/dev/shm
access (Multiprocess issues when running Ansible programically on AWS Lambda ansible/ansible#18469)This also reduces the default Xms value to 1G. I don't think we need that large of a heap nowadays (other defaults should probably be reviewed at some point).