Migrate all usages of mkdir and rmdir to buildops #1668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a refactor as one step to reduce the size/complexity of the Buildozer class. It doesn't change functionality. except to improve logging consistency and a small performance improvement * mkdir and rmdir removed from `buildozer/__init__.py` * All references to buildozer's mkdir and rmdir changed over to use buildops. * Call to Linux's mkdir via a separate shell replaced with (faster, and platform independent) library call. * Re-ordered imports, where touched, to match PEP8.
misl6
reviewed
Aug 24, 2023
buildozer/__init__.py
Outdated
| @@ -361,22 +362,22 @@ def check_build_layout(self): | |||
| exit(1) | |||
|
|
|||
| # create global dir | |||
| self.mkdir(self.global_buildozer_dir) | |||
| self.mkdir(self.global_cache_dir) | |||
| mkdir(self.global_buildozer_dir) | |||
There was a problem hiding this comment.
To help people understand that mkdir (and other methods) are from buildops, how about importing buildops and than using buildops.mkdir?
Yeah, is quite verbose, but IMHO, the readability (and the understandability) gets improved a lot.
What do you think about it?
|
I don't mind either way. Will try to get an updated version to you tomorrow.
…On Fri, 25 Aug 2023, 00:52 Mirko Galimberti, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In buildozer/__init__.py
<#1668 (comment)>:
> @@ -361,22 +362,22 @@ def check_build_layout(self):
exit(1)
# create global dir
- self.mkdir(self.global_buildozer_dir)
- self.mkdir(self.global_cache_dir)
+ mkdir(self.global_buildozer_dir)
To help people understand that mkdir (and other methods) are from buildops,
how about importing buildops and than using buildops.mkdir?
Yeah, is quite verbose, but IMHO, the readability (and the
understandability) gets improved a lot.
What do you think about it?
—
Reply to this email directly, view it on GitHub
<#1668 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHG6NJLVRSE3EKV5K76NODXW5TDFANCNFSM6AAAAAA33EM3UM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
aorizondo
pushed a commit
to aorizondo/buildozer
that referenced
this pull request
Aug 28, 2023
* Migrate all usages of mkdir and rmdir to buildops This is a refactor as one step to reduce the size/complexity of the Buildozer class. It doesn't change functionality. except to improve logging consistency and a small performance improvement * mkdir and rmdir removed from `buildozer/__init__.py` * All references to buildozer's mkdir and rmdir changed over to use buildops. * Call to Linux's mkdir via a separate shell replaced with (faster, and platform independent) library call. * Re-ordered imports, where touched, to match PEP8. * Make buildops methods more explicit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactor as one step to reduce the size/complexity of the Buildozer class. It doesn't change functionality. except to improve logging consistency and a small performance improvement
buildozer/__init__.py(cleaner versions are already inbuildops.py)