Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Secret Network docs #57

Merged
merged 6 commits into from
Aug 5, 2024
Merged

Add Secret Network docs #57

merged 6 commits into from
Aug 5, 2024

Conversation

secretpatrick
Copy link
Contributor

Adds a "Confidential Computing" category and a "Secret Network" page within it

@secretpatrick
Create _category_.json
d8e3840 
Add structure for Confidential Computing
@secretpatrick
Create secret.md
ae9f91b 
Add Secret Network page
@secretpatrick
Fix sidebar position
6003fcc 
Fix sidebar position
Eikix
Eikix reviewed Aug 1, 2024
View reviewed changes
Copy link
Member

@Eikix Eikix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Is it intentional to not include a code snippet and the gateway's address?
If so (maybe for maintainability reasons), ready to merge

Eikix
Eikix approved these changes Aug 5, 2024
View reviewed changes
Copy link
Member

@Eikix Eikix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Eikix Eikix merged commit 48262f8 into kkrt-labs:main Aug 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eikix Eikix Eikix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@secretpatrick @Eikix