新增新功能并解决存在的bug #163
Open
新增新功能并解决存在的bug #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 31, 2016 19:47
| @@ -92,7 +92,7 @@ public String addOneAppForUser(Long userId, int appId) { | |||
| User user = getUser(userId); | |||
|
|
|||
| String ownAppIds = user.getOwnApps(); | |||
| if ("admin".equals(user.getName())) { | |||
| if ("admin".equals(user.getName()) && StringUtils.isNotBlank(ownAppIds)) { | |||
There was a problem hiding this comment.
"admin"只是一个很特殊的用户，而并不是简单的管理员，这样做，是将admin唯一的管理员权限，下发到各个部门各自有自己的管理，这样便于脱离"中心管理"，当然也可以去掉这个特殊情况，但是这样，就没有一个整体的管控了、、、
|
需要进行优化下 |
| user.setName(regUserName); | ||
| user.setPassword(SignUtils.createPassword(regPwd)); | ||
| user.setToken(SignUtils.createToken(regUserName)); | ||
| user.setOwnApps("0"); | ||
| //此处给管理员的权限,就是为了admin中心权限,下方到各个部门权限 | ||
| user.setRoleId(RoleEnum.ADMIN.getValue()); |
There was a problem hiding this comment.
这样以后所有注册的用户都是管理员了？
下门到各个部分权限的意思是？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
为了方便更多用户的管理，针对源码做了如下修改：