Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve mat4 transforming performance #41

Merged
merged 1 commit into from
Oct 22, 2023
Merged

improve mat4 transforming performance #41

merged 1 commit into from
Oct 22, 2023

Conversation

Bixilon
Copy link
Member

@Bixilon Bixilon commented Oct 22, 2023

Tests passing, its actually faster and allocates 0 memory now.

@elect86 elect86 merged commit fd970a9 into master Oct 22, 2023
1 check passed
@elect86
Copy link
Collaborator

elect86 commented Oct 22, 2023

I wanted to change that sooner or later myself, thanks

@Bixilon Bixilon deleted the improve-mat4 branch October 22, 2023 20:29
@Bixilon
Copy link
Member Author

Bixilon commented Oct 22, 2023

How about a release? (also pushes to maven hopefully)

@elect86
Copy link
Collaborator

elect86 commented Oct 22, 2023

Personally I'd like to switch this to Multiplatform and then release.

I've already ported unsigned to MP, I just have to finish the last polishes and it's ready

Can you release it in the meanwhile? Which number would make sense to upgrade?

@Bixilon
Copy link
Member Author

Bixilon commented Oct 22, 2023

Can understand that. I could release but I don't want version numbers to differ from this repository and maven.

I mean it contains breaking changes, but build 12 would probably still fit?

@elect86
Copy link
Collaborator

elect86 commented Oct 22, 2023

ok, it makes sense actually, we can release it

I'll look into it, build is fine I guess?

@Bixilon
Copy link
Member Author

Bixilon commented Oct 22, 2023 via email

@Bixilon
Copy link
Member Author

Bixilon commented Oct 23, 2023

Just published the tag v0.9.9.1-build-12 which builds version 0.9.9.1-12. Not publishing it to mary though, no clue how that works.

Publishing to maven central failed, because it is not authorized. Have you stored the signing key and the credentials for in as a secret? I sent you them per email a while ago (add them https://github.com/organizations/kotlin-graphics/settings/variables/actions/new). I'll publish this release manually.

@elect86
Copy link
Collaborator

elect86 commented Oct 23, 2023

I still have theme somewhere

However, another issue I recall it now is that we have now maven central and mary, I wonder if we can automatically switch dependencies regarding where we are publishing (eg maven central shall fetch the maven central deps)

@Bixilon
Copy link
Member Author

Bixilon commented Oct 23, 2023

Sent it on 7/6/23.

That is actually a must have, otherwise things break and dependecies can not be resolved. I am not sure how to make it though. For glm it is really easy, there are no dependencies. kool and unsigned are runtime dependencies (i.e. add them if you need it). For projects that really require it, there needs to be a variable set that calles implementation in the dependecy section with the corresponding values. The other option is: Manipulating the generated pom.xml is farily easy, but changing the gradle build info (that is loaded my gradle and published too) is a hazard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants