Merge pull request #254 from kpumuk/standardrb-rspec

Switching from Rubocop to Standard completely

.github/workflows/standard.yml

@@ -1,13 +1,33 @@
 name: StandardRB
 
-on: [push]
+on:
+  push:
+  pull_request:
+    types: [opened, reopened]
+env:
+  BUNDLE_GEMFILE: gemfiles/rails_7.0.gemfile
 
 jobs:
   build:
     runs-on: ubuntu-latest
+
     steps:
-      - uses: actions/checkout@v1
-      - name: StandardRB Linter
-        uses: andrewmcodes/[email protected]
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+      - uses: actions/checkout@v3
+      - name: Set up Ruby 3.2
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: 3.2.0
+      - name: Cache gems
+        uses: actions/cache@v3
+        with:
+          path: gemfiles/vendor/bundle
+          key: ${{ runner.os }}-rubocop-${{ hashFiles('gemfiles/rails_7.0.gemfile') }}
+          restore-keys: |
+            ${{ runner.os }}-rubocop-
+      - name: Install gems
+        run: |
+          bundle config path vendor/bundle
+          bundle check || (bundle install --jobs=4 --retry=3 && bundle clean)
+      - name: Run StandardRB
+        run: |
+          bundle exec standardrb

.rubocop-rails.yml

@@ -0,0 +1,17 @@
+require:
+  - rubocop-rails
+
+inherit_gem:
+  rubocop-rails:
+    - config/default.yml
+
+AllCops:
+  TargetRailsVersion: 5.1
+
+# Do not require loading Rails environment for Rake tasks as we are not a Rails application.
+Rails/RakeEnvironment:
+  Enabled: false
+
+# Do not require subclassing from ApplicationController as we're not a rails application
+Rails/ApplicationController:
+  Enabled: false

.rubocop-rake.yml

@@ -0,0 +1,6 @@
+require:
+  - rubocop-rake
+
+inherit_gem:
+  rubocop-rake:
+    - config/default.yml

.rubocop.yml → .rubocop-rspec.yml

@@ -1,28 +1,9 @@
 require:
-  - standard
-  - rubocop-performance
-  - rubocop-rails
-  - rubocop-rake
   - rubocop-rspec
 
 inherit_gem:
-  standard: config/base.yml
-
-AllCops:
-  # Enable all the rules by default
-  EnabledByDefault: true
-  # Command line rubocop options
-  ExtraDetails: true
-  DisplayStyleGuide: true
-  DisplayCopNames: true
-  SuggestExtensions: false
-  # Target versions
-  TargetRubyVersion: 2.6
-  TargetRailsVersion: 5.1
-
-#-------------------------------------------------------------------------------
-# RSpec rules
-#-------------------------------------------------------------------------------
+  rubocop-rspec:
+    - config/default.yml
 
 RSpec/MultipleExpectations:
   Max: 7
@@ -51,15 +32,3 @@ RSpec/VerifiedDoubles:
 RSpec/NoExpectationExample:
   AllowedPatterns:
     - test_hashes_and_arrays
-
-#-------------------------------------------------------------------------------
-# Disabled rules
-#-------------------------------------------------------------------------------
-
-# Do not require loading Rails enviroment for Rake tasks as we are not a Rails application.
-Rails/RakeEnvironment:
-  Enabled: false
-
-# Do not require subclassing from ApplicationController as we're not a rails application
-Rails/ApplicationController:
-  Enabled: false

.standard.yml

@@ -0,0 +1,7 @@
+ruby_version: 2.6.0
+extend_config:
+  - .rubocop-rake.yml
+  - .rubocop-rails.yml
+  - .rubocop-rspec.yml
+ignore:
+  - "gemfiles/vendor/**/*"

meta-tags.gemspec

@@ -29,13 +29,12 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "rspec", "~> 3.12.0"
   spec.add_development_dependency "rspec-html-matchers", "~> 0.10.0"
   spec.add_development_dependency "appraisal", "~> 2.4.1"
-  spec.add_development_dependency "simplecov", "~> 0.21.2"
+  spec.add_development_dependency "simplecov", "~> 0.22.0"
   # Code style
-  spec.add_development_dependency "standard", "~> 1.18.1"
-  spec.add_development_dependency "rubocop-performance", "~> 1.15.1"
+  spec.add_development_dependency "standard", "~> 1.22.0"
   spec.add_development_dependency "rubocop-rails", "~> 2.17.3"
   spec.add_development_dependency "rubocop-rake", "~> 0.6.0"
-  spec.add_development_dependency "rubocop-rspec", "~> 2.15.0"
+  spec.add_development_dependency "rubocop-rspec", "~> 2.18.0"
   # Format RSpec output for CircleCI
   spec.add_development_dependency "rspec_junit_formatter", "~> 0.6.0"
 

spec/controller_helper_spec.rb

@@ -11,7 +11,7 @@
   end
 
   before do
-    skip("Does not work properly with RBS") if ENV["RBS_TEST_TARGET"] # rubocop:disable RSpec/Pending
+    skip("Does not work properly with RBS") if ENV["RBS_TEST_TARGET"]
   end
 
   describe "module" do

spec/view_helper/description_spec.rb

@@ -86,7 +86,7 @@
   end
 
   it "fails when title is not a String-like object" do
-    skip("Fails RBS") if ENV["RBS_TEST_TARGET"] # rubocop:disable RSpec/Pending
+    skip("Fails RBS") if ENV["RBS_TEST_TARGET"]
 
     expect {
       subject.display_meta_tags(description: 5)

spec/view_helper/title_spec.rb

@@ -183,7 +183,7 @@
     end
 
     it "fails when title is not a String-like object" do
-      skip("Fails RBS") if ENV["RBS_TEST_TARGET"] # rubocop:disable RSpec/Pending
+      skip("Fails RBS") if ENV["RBS_TEST_TARGET"]
 
       expect {
         subject.display_meta_tags(site: "someSite", title: 5)