Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ad-hoc client generation for CRDs #161

Merged
merged 3 commits into from
Jun 13, 2020
Merged

ad-hoc client generation for CRDs #161

merged 3 commits into from
Jun 13, 2020

Conversation

aespinosa
Copy link
Contributor

@aespinosa aespinosa commented Jun 12, 2020

Only works and tested in java as it's what we are using at the moment.

Introduces the following variables to a setting file:

And similar to https://github.com/kubernetes-client/java/blob/master/docs/generate-model-from-third-party-resources.md, OPENAPI_SKIP_FETCH_SPEC is needed.

Added codepaths in preprocess_spec.py to address kubernetes-client/java#921 by replacing the whole ListMeta tree with $ref: #/definitions/v1.ListMeta

Addresses #121

cc @brendanburns @yue9944882

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 12, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @aespinosa!

It looks like this is your first PR to kubernetes-client/gen 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/gen has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 12, 2020
@aespinosa
Copy link
Contributor Author

/assign @brendanburns

@k8s-ci-robot
Copy link
Contributor

@aespinosa: GitHub didn't allow me to assign the following users: brendanburns.

Note that only kubernetes-client members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @brendanburns

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aespinosa
Copy link
Contributor Author

/assign @mbohlool

@brendandburns
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aespinosa, brendandburns

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 13, 2020
@k8s-ci-robot k8s-ci-robot merged commit deac82e into kubernetes-client:master Jun 13, 2020
@aespinosa aespinosa deleted the crd-mode branch June 14, 2020 03:09
@yue9944882
Copy link
Member

this is awesome! let me adjust the guide doc on the java repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants