Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add generic and typed watch to KubernetesObjectApi #1831

Merged
merged 3 commits into from
Aug 27, 2024
Merged

add generic and typed watch to KubernetesObjectApi #1831

merged 3 commits into from
Aug 27, 2024

Conversation

schrodit
Copy link
Contributor

Follow up of #1705 (comment)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 10, 2024
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 10, 2024
schrodit
schrodit commented Aug 10, 2024
View reviewed changes
src/object.ts Show resolved Hide resolved
schrodit
schrodit commented Aug 10, 2024
View reviewed changes
src/object.ts Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 10, 2024
@schrodit
Copy link
Contributor Author

/assign mstruebing

@brendandburns
Copy link
Contributor

This looks good to me. Any chance that you can add unit tests? If not I'll do it as a follow up.

@brendandburns
Copy link
Contributor

Looks like CI/CD is failing for some reason.

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 17, 2024
@schrodit
Copy link
Contributor Author

This looks good to me. Any chance that you can add unit tests? If not I'll do it as a follow up.

added some tests

@schrodit
Copy link
Contributor Author

/assign @brendandburns

@mstruebing
Copy link
Member

This looks like a great PR, thanks! 🚀

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 19, 2024
mstruebing
mstruebing reviewed Aug 21, 2024
View reviewed changes
src/util.ts Outdated Show resolved Hide resolved
@brendandburns @mstruebing
Update src/util.ts
d5b673c 
Co-authored-by: Max Strübing <[email protected]>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 23, 2024
@schrodit
Copy link
Contributor Author

@mstruebing can you take another look?

Do we have to port it to the release-1 branch?

@brendandburns
Copy link
Contributor

/lgtm
/approve

Thanks for the PR. It would be appreciated (but not required) to port this to the 1.x branch also.

Soon the 0.x branch will be deprecated and will be replaced by the 1.x branch.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 27, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, schrodit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 27, 2024
@k8s-ci-robot k8s-ci-robot merged commit e3117a4 into kubernetes-client:master Aug 27, 2024
7 checks passed
@schrodit schrodit deleted the generic-watch branch August 27, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mstruebing mstruebing mstruebing left review comments

@brendandburns brendandburns Awaiting requested review from brendandburns

Assignees

@brendandburns brendandburns

@mstruebing mstruebing

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@schrodit @brendandburns @mstruebing @k8s-ci-robot