More GEP-2257 tweaks #2269
Merged
More GEP-2257 tweaks #2269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This approach is less fragile, and also allows all three implementations (Rust, Go, and Python) to work in a similar way. Signed-off-by: Flynn <[email protected]>
Signed-off-by: Flynn <[email protected]>
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
size/M
yliaog
reviewed
Aug 21, 2024
Signed-off-by: Flynn <[email protected]>
kflynn
force-pushed
the
flynn/dev/gep-2257-tweaks
branch
from
9cb44f5
to
f05c642
Compare
|
/lgtm |
|
/test |
|
@yliaog: No presubmit jobs available for kubernetes-client/python@master In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kflynn, yliaog The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is best reviewed commit by commit.
First, refactor the formatter for GEP-2257 durations to just do things by hand rather than relying on durationpy's formatter. This is primarily a less fragile approach, but it also allows the three extant GEP-2257 implementations (Rust, Go, and Python) to be more similar.
Second, add an example program. Should've done this earlier.
/kind cleanup