Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve observability of InsufficientVolumeCapacity errors #2155

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve observability of InsufficientVolumeCapacity errors #2155

wants to merge 1 commit into from
+28 −0

Conversation

torredil
Copy link
Member

Is this a bug fix or adding new feature?

Neither, kaizen.
closes #2154

What is this PR about? / Why do we need it?

This PR enhances the driver's ability to communicate InsufficientVolumeCapacity errors from the AWS API by providing a more informative error message to users.

What testing is done?

make verify && make test

See https://docs.aws.amazon.com/AWSEC2/latest/APIReference/errors-overview.html for more information related to error codes.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 19, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from torredil. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 19, 2024
@github-actions GitHub Actions
Copy link

Code Coverage Diff

This PR does not change the code coverage

@torredil
Copy link
Member Author

/retest

AndrewSirenko
AndrewSirenko reviewed Sep 20, 2024
View reviewed changes
pkg/cloud/cloud_test.go
AvailabilityZone: expZone,
},
expCreateVolumeInput: &ec2.CreateVolumeInput{
Iops: aws.Int32(2000),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason we need this iops input?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 20, 2024
@k8s-ci-robot
Copy link
Contributor

@torredil: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-aws-ebs-csi-driver-test-e2e-external-eks-windows ba9c02c link true /test pull-aws-ebs-csi-driver-test-e2e-external-eks-windows

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

ConnorJC3
ConnorJC3 requested changes Sep 20, 2024
View reviewed changes
pkg/cloud/cloud.go
@@ -176,6 +176,9 @@ var (

// ErrInvalidRequest is returned if parameters were rejected by driver
ErrInvalidRequest = errors.New("invalid request")

// ErrInsufficientVolumeCapacity is returned when there's not enough capacity to fulfill the volume provision request.
ErrInsufficientVolumeCapacity = errors.New("There is not enough capacity to fulfill your EBS volume provision request. You can try to provision a different volume type, EBS volume in a different availability zone, or you can wait for additional capacity to become available.")
Copy link
Contributor

@ConnorJC3 ConnorJC3 Sep 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we adding our own error message here? Is the error message from EBS not sufficient?

(What even is the error message the EBS API returns here? Neither the PR nor the linked issue contains it)

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 20, 2024
@AndrewSirenko AndrewSirenko mentioned this pull request Sep 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ConnorJC3 ConnorJC3 ConnorJC3 requested changes

@AndrewSirenko AndrewSirenko AndrewSirenko approved these changes

Assignees

@ConnorJC3 ConnorJC3

@AndrewSirenko AndrewSirenko

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

insufficient capacity API possibly errors not propagating into logs and events
4 participants
@torredil @k8s-ci-robot @ConnorJC3 @AndrewSirenko