Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dump resources on delete timeout #5120

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nojnhuh
Copy link
Contributor

@nojnhuh nojnhuh commented Sep 9, 2024

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

This PR takes advantage of kubernetes-sigs/cluster-api#10961 new in CAPI 1.8 to dump resources when a delete operation times out like we've been seeing with AKS clusters recently.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

  • cherry-pick candidate

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 9, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from nojnhuh. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 9, 2024
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.25%. Comparing base (ffa6415) to head (eea97ee).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5120      +/-   ##
==========================================
- Coverage   51.25%   51.25%   -0.01%     
==========================================
  Files         273      273              
  Lines       24651    24651              
==========================================
- Hits        12636    12634       -2     
- Misses      11229    11231       +2     
  Partials      786      786              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 10, 2024
@nojnhuh
Copy link
Contributor Author

nojnhuh commented Sep 10, 2024

/test pull-cluster-api-provider-azure-e2e-aks

@nojnhuh
Copy link
Contributor Author

nojnhuh commented Sep 10, 2024

/retest

@nojnhuh
Copy link
Contributor Author

nojnhuh commented Sep 10, 2024

/test pull-cluster-api-provider-azure-e2e-aks

2 similar comments
@nojnhuh
Copy link
Contributor Author

nojnhuh commented Sep 10, 2024

/test pull-cluster-api-provider-azure-e2e-aks

@nojnhuh
Copy link
Contributor Author

nojnhuh commented Sep 10, 2024

/test pull-cluster-api-provider-azure-e2e-aks

@k8s-ci-robot
Copy link
Contributor

@nojnhuh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-azure-e2e-aks eea97ee link true /test pull-cluster-api-provider-azure-e2e-aks

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@nojnhuh
Copy link
Contributor Author

nojnhuh commented Sep 10, 2024

The most recent e2e test failure shows this is working as expected.

/retitle dump resources on delete timeout

@k8s-ci-robot k8s-ci-robot changed the title [WIP] dump resources on delete timeout dump resources on delete timeout Sep 10, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Status: Needs Review
Development

Successfully merging this pull request may close these issues.

2 participants