-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dump resources on delete timeout #5120
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5120 +/- ##
==========================================
- Coverage 51.25% 51.25% -0.01%
==========================================
Files 273 273
Lines 24651 24651
==========================================
- Hits 12636 12634 -2
- Misses 11229 11231 +2
Partials 786 786 ☔ View full report in Codecov by Sentry. |
/test pull-cluster-api-provider-azure-e2e-aks |
/retest |
/test pull-cluster-api-provider-azure-e2e-aks |
2 similar comments
/test pull-cluster-api-provider-azure-e2e-aks |
/test pull-cluster-api-provider-azure-e2e-aks |
@nojnhuh: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
The most recent e2e test failure shows this is working as expected. /retitle dump resources on delete timeout |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR takes advantage of kubernetes-sigs/cluster-api#10961 new in CAPI 1.8 to dump resources when a delete operation times out like we've been seeing with AKS clusters recently.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs:
Release note: