Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rancher Application Collection subsection, verify images #443

Merged
merged 3 commits into from
Aug 22, 2024

Conversation

viccuad
Copy link
Member

@viccuad viccuad commented Aug 21, 2024

Description

Add Rancher Application Collection subsection, add verify images page.
Clarify the usage of imagePullSecret for PolicyServers.

Test

I have tested this commands by hand.

Additional Information

Tradeoff

Potential improvement

@viccuad viccuad requested a review from a team as a code owner August 21, 2024 14:57
Copy link

netlify bot commented Aug 21, 2024

Deploy Preview for silly-bunny-8cedd0 ready!

Name Link
🔨 Latest commit 366419d
🔍 Latest deploy log https://app.netlify.com/sites/silly-bunny-8cedd0/deploys/66c735e90ec01500088d3af4
😎 Deploy Preview https://deploy-preview-443--silly-bunny-8cedd0.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@jhkrug jhkrug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor typos and suggestions

docs/howtos/application-collection/01-verify-images.md Outdated Show resolved Hide resolved
docs/howtos/application-collection/01-verify-images.md Outdated Show resolved Hide resolved
docs/howtos/application-collection/01-verify-images.md Outdated Show resolved Hide resolved
Co-authored-by: John Krug <[email protected]>
Signed-off-by: Víctor Cuadrado Juan <[email protected]>
@viccuad viccuad requested a review from jhkrug August 22, 2024 12:58
Copy link
Contributor

@jhkrug jhkrug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@viccuad viccuad merged commit b9e7f59 into kubewarden:main Aug 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants