-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explain how certificate rotation works #446
Conversation
Kubewarden controller now manages its own certificates structure. Therefore, it's not necessary to install cert-manager anymore. This commit removes the references to the cert-manager in the documentation. Signed-off-by: José Guilherme Vanz <[email protected]>
✅ Deploy Preview for silly-bunny-8cedd0 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor suggestions, thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some comments added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
cert-manager is a requirement of OpenTelemetry, but we've already installed | ||
them in a previous section of this book. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this is no longer true, we haven't covered the installation of cert-manager in other parts of the book. Have we?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we have. But not because of Kubewarden. OpenTelemetry uses CertManager to generate certificates by default. https://deploy-preview-446--silly-bunny-8cedd0.netlify.app/howtos/telemetry/opentelemetry-qs#install-opentelemetry
| Chart dependency | Helm chart `appVersion` | Helm chart `version` | Comments | | ||
| ----------------------------- | :---------------------: | :------------------: | :--------------------: | | ||
| `jetstack/cert-manager` chart | `>= 1.13 < 2` | Example: `v1.13.2` | Plans to make optional | | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's fine to drop this section. I would not move it down into the "optional dependencies" as a dependency of OpenTelemetry. That's because OpenTelemetry has its own documentation stating what is required
cert-manager is a requirement of OpenTelemetry, but we've already installed | ||
them in a previous section of this book. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We haven't installed it before, have we?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we have. But not because of Kubewarden. OpenTelemetry uses CertManager to generate certificates by default. https://deploy-preview-446--silly-bunny-8cedd0.netlify.app/howtos/telemetry/opentelemetry-qs#install-opentelemetry
Adds a new page in the explanation section of the documentation to clarify how the new certification rotation works. Signed-off-by: José Guilherme Vanz <[email protected]> Co-authored-by: John Krug <[email protected]> Co-authored-by: Flavio Castelli <[email protected]>
Signed-off-by: John Krug <[email protected]>
Description
Adds a new page in the explanation section of the documentation to clarify how the new certification rotation works.
Fix #252