-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(docs): explanation page about policy groups. #453
Conversation
✅ Deploy Preview for silly-bunny-8cedd0 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor suggestions for your consideration.
@jhkrug: can you take another look please? I've done quite some changes to the initial doc. @fabriziosestito: can you take a look too please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a couple of nitpicks added.
6242e66
to
197d97c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few tiny suggestions. Otherwise, lgtm.
Adds a new page in the documentation explaining how the policy group types works. Signed-off-by: José Guilherme Vanz <[email protected]> Co-authored-by: John Krug <[email protected]> Co-authored-by: Flavio Castelli <[email protected]>
031f9ea
to
c117b35
Compare
Thanks for all the suggestions and fixes. I've incorporated them |
Description
Adds a new page in the documentation explaining how the policy group types works.
Fix #448