Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): explanation page about policy groups. #453

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

jvanz
Copy link
Member

@jvanz jvanz commented Sep 13, 2024

Description

Adds a new page in the documentation explaining how the policy group types works.

Fix #448

@jvanz jvanz requested a review from a team as a code owner September 13, 2024 18:47
Copy link

netlify bot commented Sep 13, 2024

Deploy Preview for silly-bunny-8cedd0 ready!

Name Link
🔨 Latest commit c117b35
🔍 Latest deploy log https://app.netlify.com/sites/silly-bunny-8cedd0/deploys/66ed7f913312120008a5ba7a
😎 Deploy Preview https://deploy-preview-453--silly-bunny-8cedd0.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@jhkrug jhkrug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor suggestions for your consideration.

docs/explanations/policy-groups.md Outdated Show resolved Hide resolved
docs/explanations/policy-groups.md Outdated Show resolved Hide resolved
docs/explanations/policy-groups.md Outdated Show resolved Hide resolved
docs/explanations/policy-groups.md Outdated Show resolved Hide resolved
docs/explanations/policy-groups.md Outdated Show resolved Hide resolved
docs/explanations/policy-groups.md Outdated Show resolved Hide resolved
docs/explanations/policy-groups.md Outdated Show resolved Hide resolved
docs/explanations/policy-groups.md Outdated Show resolved Hide resolved
docs/explanations/policy-groups.md Outdated Show resolved Hide resolved
docs/explanations/policy-groups.md Outdated Show resolved Hide resolved
@flavio
Copy link
Member

flavio commented Sep 19, 2024

@jhkrug: can you take another look please? I've done quite some changes to the initial doc.

@fabriziosestito: can you take a look too please?

Copy link
Contributor

@fabriziosestito fabriziosestito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple of nitpicks added.

docs/explanations/policy-groups.md Outdated Show resolved Hide resolved
docs/explanations/policy-groups.md Outdated Show resolved Hide resolved
Copy link
Contributor

@jhkrug jhkrug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few tiny suggestions. Otherwise, lgtm.

docs/explanations/policy-groups.md Outdated Show resolved Hide resolved
docs/explanations/policy-groups.md Outdated Show resolved Hide resolved
docs/explanations/policy-groups.md Outdated Show resolved Hide resolved
Adds a new page in the documentation explaining how the policy group
types works.

Signed-off-by: José Guilherme Vanz <[email protected]>
Co-authored-by: John Krug <[email protected]>
Co-authored-by: Flavio Castelli <[email protected]>
@flavio
Copy link
Member

flavio commented Sep 20, 2024

Thanks for all the suggestions and fixes. I've incorporated them

@flavio flavio merged commit e7ad055 into kubewarden:main Sep 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PolicyGroup: add explanation page
4 participants