-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(policy): automatically convert policy yaml #1290
Conversation
✅ Deploy Preview for kuma ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@fabianrbz for this to be usable in both Kuma and Kong-Mesh we need to extract this in a gem? |
Putting this as draft as we need to extract this to make it usable in both doc sites |
I am missing one thing here. I think it is beneficial to have policies that have service names easily understandable on every platform. For example on universal you can set service name to any value like: Another topic I think it would be also helpful for users to base all policies example on demo app, so they can simply play with them and apply them without changing anything. |
f84f3d4
to
a42534f
Compare
Makes sense my guess is that this could be done as a follow up |
@jakubdyszkiewicz is this already working with the new reusable plugin stuff in #1303? |
@michaelbeaumont It doesn't. Is there a repo or something to this plugin to the gem? |
@jakubdyszkiewicz It's in this repo, I think you just have to make changes similar to 46e2f01 |
It seems it's there, Charly moved this around |
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
b5d64dd
to
0678898
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! LGTM
created an issue for name conversion #1359 |
Add plugin to generate policy tabs for universal and kubernetes and automatically convert universal yaml to kubernetes yaml.
I changed only one file, but once this is merged I'll go over all occurrences in the project to clean it up.
The difference with MeshCircuitBreaker is that we are missing
and
I don't find this useful, but I can also add this information to an HTML generated by the plugin. It can be even opt-in.